magithub icon indicating copy to clipboard operation
magithub copied to clipboard

Allow magithub-edit buffers to invoke popups upon submission

Open vermiculus opened this issue 7 years ago • 2 comments
trafficstars

From #264.

Right now, this is a little complicated. Once a popup is invoked, control returns back to the top-level while the popup waits for user input. As this happens (i.e., immediately when magit-invoke-popup returns), magithub-edit-submit closes the buffer and tries to get every buffer back to the way it was.

We could work around this limitation by using a special return symbol in the callback to avoid all this. This will be...complicated.

@tarsius -- re transient.el, I don't expect you'll be changing this behavior from magit-popup into transient.el, but I'd thought I'd ask.

vermiculus avatar Feb 03 '18 18:02 vermiculus

That's right.

tarsius avatar Feb 03 '18 19:02 tarsius

Thanks :-)

vermiculus avatar Feb 03 '18 20:02 vermiculus