magithub icon indicating copy to clipboard operation
magithub copied to clipboard

magithub-github-repository-p only checks "origin" as the single possible GitHub remote name

Open whirm opened this issue 8 years ago • 2 comments

It would be great if magithub checked all remotes, I often don't have an "origin" remote on local repos.

whirm avatar Aug 10 '17 09:08 whirm

What kind of interface would be ideal? Consider the possibility that more than one remote could point to a repository (as is the case with fork; cf. #106).

Note also that the proxy functionality can already handle situations like this.

vermiculus avatar Aug 10 '17 13:08 vermiculus

If magithub-ghub-repository-p doesn't find a remote named origin the whole functionality gets disabled. If all remotes where checked regardless of the name they have, then magithub could check which one is the original repo and which are forks. Although this is much more complicated than what you are doing now.

Maybe just being able to customize the upstream remote name would be enough? I usually name the upstream remote upstream and the other remotes with the github username of the repo they point to.

whirm avatar Aug 11 '17 10:08 whirm