twirpy icon indicating copy to clipboard operation
twirpy copied to clipboard

Published 20 hours ago • verified publisher icon verloop

Add wsgi support

Open ofpiyush opened this issue 4 years ago • 4 comments

ofpiyush avatar Mar 13 '20 09:03 ofpiyush

hi @ofpiyush !

thanks for working this issue, just wanted to check in and see if there are still any plans on getting this merged ?

drish avatar Apr 13 '21 21:04 drish

Hi @drish

At the time, I had stopped because I needed to focus on something else.

When I came back with a fresh perspective, I couldn't find a compelling reason to support WSGI.

Right now, this issue is waiting for that compelling reason.

ofpiyush avatar Apr 14 '21 01:04 ofpiyush

hey @ofpiyush okay, thanks for the update here !

So I think for anybody using a WSGI framework, the option would be to use https://github.com/daroot/protoc-gen-twirp_python_srv, since twirpy only support ASGI frameworks ?

drish avatar Apr 14 '21 21:04 drish

Last when I'd talked to Dan, he mentioned that it's still Python2 and he's unlikely to spend effort on the project as he's moved on from the job.

There's a branch with untested wsgi code on this as well based off of Dan's work.

https://github.com/verloop/twirpy/pull/17

If you can provide a compelling case for WSGI, I'd add it.

ofpiyush avatar Apr 15 '21 00:04 ofpiyush