vtr-verilog-to-routing
vtr-verilog-to-routing copied to clipboard
verilog-to-routing
[Bison] Raised Minimum Bison Version to 3.3
Raised the minimum Bison version from 3.0 to 3.3 to handle deprecation warnings.
Description
In recent versions of Bison, the parser_class_name directive has been deprecated for api.parser.class.
See issue #2518
The issue is that api.parser.class was not introduced until Bison 3.3. Currently the minimum Bison version for libblifparse and libsdcparse is Bison 3.0 (which is the same version we use on our development machines). To properly fix these warnings we would need to raise the minimum Bison version to Bison 3.3 and resolve the deprecation.
@vaughnbetz What do you think about this? To prevent having to raise the minimum Bison version to Bison 3.3, I have suppressed the deprecation warning only in the two affected yacc files. I have verified that this fixes the warnings.
This is a good question for the Thursday meeting in my opinion (if you can bring up a quick summary). It is a bit dangerous to suppress a deprecation warning, but I guess it will error if they ever fully deprecate it ...
@vaughnbetz I agree, I think this is a great topic to bring up! However, I will not be at the one this week. I could bring it up next week! I do not think this is very time sensitive.
Two weeks is fine. You could bring up any thorny ones there, plus overall status on getting warning clean.
Keeping this one around -- will merge once we've updated to a recent enough Ubuntu on CI and all systems we care about.