vtr-verilog-to-routing
vtr-verilog-to-routing copied to clipboard
verilog-to-routing
Re-clustering API bug fixes
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
- [ ] Bug fix (change which fixes an issue)
- [ ] New feature (change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [ ] My change requires a change to the documentation
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] All new and existing tests passed
@MohamedElgammal some tests failed due to download issues --> relaunch? Adding @AlexandreSinger as a potential reviewer.
@MohamedElgammal : should this PR be landed? @KA7E may be interested in these fixes.
looking good to me .. We need to have a second look on the failing tests ... let me rerun them and update you
I think the 4 Clang CI build failures are caused by this branch being behind VTR master by some time. I think rebasing it onto VTR master should resolve the issue. @MohamedElgammal could you rebase the branch? I see a button to do so, but I am not sure if doing it from the GitHub UI would cause any issues.
I have rebased the branch using the GitHub UI. Hopefully the tests should pass now and this can be merged in.
Great, thanks. @MohamedElgammal : any barrier to merging this if CI passes?
@AlexandreSinger : I believe this is the branch that has an example of how to use the re-clustering API.
https://github.com/verilog-to-routing/vtr-verilog-to-routing/tree/packing-multithreading
(see pack_utils.cpp)
@AlexandreSinger : Thanks for rebasing it. @vaughnbetz : this branch should be good to be merged if it passes (I think it will pass anyway as the API isn't used in the master branch). My plan is to add unit tests for the different use cases of the API functions but never got to this task.