vtr-verilog-to-routing icon indicating copy to clipboard operation
vtr-verilog-to-routing copied to clipboard

VPR Pack: C-style Arrays to C++ Vectors

Open jmah76 opened this issue 2 years ago • 0 comments

Related to PR #2084 Change the C arrays in vpr/pack that get delete[] called on them to C++ vectors.

Using delete[] indicates that this is some sort of array which might be an opportunity to replace with std::array or std::vector depending on the context. The requirement for delete[] should be rare if we have such containers (like what you did above already successfully with the pin_timing etc. containers) (From https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/2084#discussion_r915056221)

could the hill_climbing_inputs_avail be a std::vector ? They are automatically 0 initialized and we just would call resize(helper_ctx.max_cluster_size + 1) here. (From https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/2084#discussion_r915064384)

jmah76 avatar Jul 07 '22 22:07 jmah76