vtr-verilog-to-routing icon indicating copy to clipboard operation
vtr-verilog-to-routing copied to clipboard

Published 20 hours ago • verified publisher icon verilog-to-routing

Fix build errors with VERBOSE

Open mkurc-ant opened this issue 2 years ago • 5 comments

This PR contains some general fixes

Description

The PR fixes build errors when VERBOSE is defined. It also fixes VPR ignoring netlist verbosity commandline option.

Related Issue

Motivation and Context

The need for debugging

How Has This Been Tested?

Locally, and hopefully in the CI

Types of changes

  • [x] Bug fix (change which fixes an issue)
  • [ ] New feature (change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] My change requires a change to the documentation
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] All new and existing tests passed

mkurc-ant avatar Jun 09 '22 13:06 mkurc-ant

@mkurc-ant - We should make sure that this is checked in CI somewhere?

mithro avatar Jun 09 '22 16:06 mithro

Thanks. Changes look good, but need a make format to pass CI.

vaughnbetz avatar Jun 09 '22 23:06 vaughnbetz

Sure. I'll add a CI test to check compilation with VERBOSE enabled + do code formatting.

mkurc-ant avatar Jun 10 '22 09:06 mkurc-ant

Sorry, didn't merge this fast enough and it has conflict now. Can you resolve them and ping me @mkurc-ant ?

vaughnbetz avatar Aug 15 '22 19:08 vaughnbetz

Hi @vaughnbetz, I've resolved the conflict and rebased this PR on the current master.

mkurc-ant avatar Aug 22 '22 10:08 mkurc-ant