vtr-verilog-to-routing icon indicating copy to clipboard operation
vtr-verilog-to-routing copied to clipboard

Published 20 hours ago • verified publisher icon verilog-to-routing

WIP: clang-tidy fixes around const std::string references.

Open mithro opened this issue 3 years ago • 2 comments

Description

This is the clang-tidy fixes that @luk036 had in his pull request at https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/1078

These changes make the code follow closer to best practices around using const std::string references.

mithro avatar Jun 03 '21 21:06 mithro

This change isn't quite ready to be merged yet as it currently includes changes to code under libs/EXTERNAL. These need to be extracted out of the pull request and sent to the appropriate external projects.

mithro avatar Jun 03 '21 21:06 mithro

@luk036 : feedback from @hzeller on these clang-tidy changes. Looks like we'd only want a subset of them.

vaughnbetz avatar Jun 17 '21 18:06 vaughnbetz