bayes_logistic icon indicating copy to clipboard operation
bayes_logistic copied to clipboard

sklean style api

Open mariusvniekerk opened this issue 10 years ago • 3 comments

Initial draft of an sklearn style api

mariusvniekerk avatar Sep 22 '15 14:09 mariusvniekerk

If you decide you want to depend on scikit-learn, I'd encourage you to run this function in your unit tests: https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/utils/estimator_checks.py#L219

It is new in 0.17 and checks scikit-learn compatibility. Also see the docs here: http://scikit-learn.org/dev/developers/contributing.html#rolling-your-own-estimator

(they also contain more details on set_params and get_params)

You could also make scikit-learn an optional dependency, so that it can be used to test compatibility but is not required by the user.

amueller avatar Nov 18 '15 19:11 amueller

@mariusvniekerk what's the status of this PR?

ericdill avatar Feb 27 '17 16:02 ericdill

Basically needs refactoring to be closer to Andreas' suggestion

mariusvniekerk avatar Feb 27 '17 16:02 mariusvniekerk