OpenNotrium icon indicating copy to clipboard operation
OpenNotrium copied to clipboard

Menu music not playing when returning to menu

Open verhoevenv opened this issue 9 years ago • 1 comments

I suspect the intention was to make the menu music play whenever the menu is shown, however there's a bug in that code: at https://github.com/verhoevenv/OpenNotrium/blob/96bad237cbbc4f162bd7e45dc9866934768385fa/WinMain.cpp#L1340

SwapSourceFilter("music/menu/menu.mp3");

references an unknown file, it should be

SwapSourceFilter("music/menu.mp3");

verhoevenv avatar Apr 28 '15 21:04 verhoevenv

I would prefer moving any hard-coded file names like those into a single place. And the fact that we're calling a function called "SwapSourceFilter" in the main file doesn't comfort me either. :P

Enet4 avatar Apr 29 '15 16:04 Enet4