Don't use default 1 for replicaCount

Open Hechamon opened this issue 1 year ago • 1 comments

Since default handles 0 (zero) as "not set", it's currently impossible to scale the helm chart to 0 replicas. The default value in the values file is 1 anyways, so this should not cause a breaking change.

I have a usecase where I need to scale the deployment to zero for our passive, warm backup cluster, which is currently not possible. This change would allow that.

Aug 07 '24 14:08 Hechamon

Hi @verdaccio/kubernetes :-)

Could you have a look at this PR? Thank you so much.

Aug 22 '24 11:08 Hechamon

Hi @verdaccio/kubernetes :-)

Could you have a look at this PR? Thank you so much.

Just did, :) 🌴 summer season

Oct 01 '24 20:10 juanpicado

Would you mind solves red checks and we can move on

Oct 02 '24 19:10 juanpicado

This was already added to master in PR #152

Oct 07 '24 08:10 Hechamon