vercel icon indicating copy to clipboard operation
vercel copied to clipboard

Published 20 hours ago • verified publisher icon vercel

[frameworks] Add VuePress and VitePress

Open lydiahallie opened this issue 2 years ago • 4 comments

This PR adds VuePress and VitePress the list of supported frameworks.

  • https://vuepress-starter-template.vercel.app
  • https://vitepress-starter-template.vercel.app

Tests

  • [x] The code changed/added as part of this PR has been covered with tests
  • [x] All tests pass locally with yarn test-unit

lydiahallie avatar May 18 '22 03:05 lydiahallie

I wonder if we need the VITE_ prefix: https://github.com/vercel/vercel/blob/main/packages/frameworks/src/frameworks.ts#L1997

leerob avatar May 19 '22 01:05 leerob

I wonder if we need the VITE_ prefix: https://github.com/vercel/vercel/blob/main/packages/frameworks/src/frameworks.ts#L1997

The prefix is used to feed the deployment with the Vercel system environment variables as "public" environment variables. Typically this is a prefix that the framework will document as a way to mark an environment "safe" to be exposed public, like NEXT_PUBLIC_.

I could not find anything related to it in the respective docs (Vitepress and Vuepress), so I think it's fine to leave them out.

lucleray avatar May 25 '22 08:05 lucleray

Maybe we should include this: https://twitter.com/KiaKing85/status/1532019802055000070

leerob avatar Jun 01 '22 22:06 leerob

Agreed. Waiting until stable 1.0.0 makes sense unless we can get a garantee from the framework author that build/dev/output settings won't change.

styfle avatar Jun 01 '22 23:06 styfle

@lydiahallie @leerob This appears to be causing failures for a popular OSS project called RSSHub

https://github.com/DIYgod/RSSHub/issues/11647#issuecomment-1410789482

styfle avatar Feb 27 '23 22:02 styfle