turbo icon indicating copy to clipboard operation
turbo copied to clipboard

chore(logging): Improved logs when using errors-only.

Open anthonyshew opened this issue 1 year ago • 3 comments

Question: Will this create log groups in CI that previously didn't exist? Leaving as draft until I learn more on this (and if the team thinks this is a good change).

Description

Previously, errors-only wouldn't log anything on a successful task. Your tasks would be running, but turbo appeared to be hanging. The task would only print the "leader log" that its running when it errors so you'd get no visual feedback that it even started.

With a few more thoughtful logs, we can make it more clear that your tasks are currently running (though there aren't logs printing).

Considerations

This is a bit of a spiritual departure from truly being logging with strictly only errors but I'm of the opinion that the trade is worth it after reading https://github.com/vercel/turbo/issues/4042. I've also played with this in a few larger repos to find out how it feels and I'm finding it to be an improvement (though I'm open to feedback otherwise!)

Testing Instructions

👀

Screenshots

Note that these screenshots don't show the timing of the logs well. You'd previously only get the log that the task was happening after it already errored but now it shows when the task starts.

  • Mix of cache misses and hits CleanShot 2024-07-30 at 23 11 29

  • All successful hits CleanShot 2024-07-30 at 23 14 42

  • With cache disabled and failures CleanShot 2024-07-30 at 23 12 13

  • With cache disabled and successes CleanShot 2024-07-30 at 23 13 57

anthonyshew avatar Jul 31 '24 05:07 anthonyshew

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 8:32pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 8:32pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 8:32pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 8:32pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 8:32pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 8:32pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 8:32pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 8:32pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 8:32pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2025 8:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rust-docs ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2025 8:32pm

vercel[bot] avatar Jul 31 '24 05:07 vercel[bot]

🟢 Turbopack Benchmark CI successful 🟢

Thanks

github-actions[bot] avatar Jul 31 '24 05:07 github-actions[bot]

🟢 CI successful 🟢

Thanks

github-actions[bot] avatar Jul 31 '24 05:07 github-actions[bot]