turbo icon indicating copy to clipboard operation
turbo copied to clipboard

[WIP] Fix Framework Inference for eslint-config-turbo.

Open anthonyshew opened this issue 1 year ago • 5 comments

Description

A fairly naive implementation of Framework Inference (as it stands at the moment). turbo's Framework Inference support is per-package whereas this one wholesale allowslists all framework environment variables in every package.

I tried my hand at making it per-package but fell flat. Could use some assistance if we don't think this is sufficient. From my perspective, the risk of someone using the wrong vars in the wrong framework is minimal and this is an improvement on our current support (which is none at all).

Testing Instructions

Double-checking the tests I have would be great. I've never written an ESLint plugin before and had...quite a time with this.

anthonyshew avatar Jun 15 '24 16:06 anthonyshew

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2024 9:04pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2024 9:04pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2024 9:04pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2024 9:04pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2024 9:04pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2024 9:04pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2024 9:04pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2024 9:04pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2024 9:04pm
rust-docs ⬜️ Ignored (Inspect) Visit Preview Jun 15, 2024 9:04pm

vercel[bot] avatar Jun 15 '24 16:06 vercel[bot]

🟢 Turbopack Benchmark CI successful 🟢

Thanks

github-actions[bot] avatar Jun 15 '24 16:06 github-actions[bot]

🟢 CI successful 🟢

Thanks

github-actions[bot] avatar Jun 15 '24 16:06 github-actions[bot]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/..%[email protected] None 0 0 B
npm/[email protected] environment, eval, filesystem, network, shell, unsafe +41 274 MB vitebot

View full report↗︎

socket-security[bot] avatar Jun 15 '24 16:06 socket-security[bot]

:white_check_mark: This change can build next-swc

github-actions[bot] avatar Jun 15 '24 18:06 github-actions[bot]