turbo icon indicating copy to clipboard operation
turbo copied to clipboard

feature: Add invalidate flag to logout

Open Zertsov opened this issue 1 year ago • 4 comments

Description

Allows for turbo logout --invalidate which should call to the API to actually remove the token from the account.

Closes TURBO-2406

Zertsov avatar Feb 21 '24 00:02 Zertsov

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 3:38pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 3:38pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 3:38pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 3:38pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2024 3:38pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2024 3:38pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2024 3:38pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2024 3:38pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2024 3:38pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2024 3:38pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2024 3:38pm

vercel[bot] avatar Feb 21 '24 00:02 vercel[bot]

  • #7444 Graphite 👈
  • #7443 Graphite
  • #7407 Graphite
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Zertsov and the rest of your teammates on Graphite Graphite

Zertsov avatar Feb 21 '24 00:02 Zertsov

🟢 Turbopack Benchmark CI successful 🟢

Thanks

github-actions[bot] avatar Feb 21 '24 00:02 github-actions[bot]

🟢 CI successful 🟢

Thanks

github-actions[bot] avatar Feb 21 '24 01:02 github-actions[bot]

We need to increase our automated test coverage for the codebase.

A few notes:

  • A successful turbo_dev logout --invalidate doesn't have any output, hard to tell if it succeeded or not
  • Trying to login with an invalidated token has a very unhelpful error message:
[1 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ turbo_dev login --sso-team=vercel
 × Error making HTTP request: error decoding response body: missing field `token` at line 1 column 77
 ├─▶ error decoding response body: missing field `token` at line 1 column 77
 ╰─▶ missing field `token` at line 1 column 77

Agreed that the output should be there, I can fix that quick. The login seems to be a separate issue though.

Zertsov avatar Mar 01 '24 23:03 Zertsov

Merge activity

  • Mar 7, 11:00 AM EST: @Zertsov merged this pull request with Graphite.

Zertsov avatar Mar 07 '24 16:03 Zertsov