turbo icon indicating copy to clipboard operation
turbo copied to clipboard

chore: proper description of turbo pack

Open ThePrimeagen opened this issue 2 years ago • 403 comments

The description of turbo was lacking the credentials, both on the streets and in the sheets. I took the liberty of properly identifying, commiting, and leading this change across several teams, including, but not limited to UI Engineering at TheStartup™. After identifying we committed. I personally was a fan of fugitive, but i now use neogit, which still allows for committing. Finally, the fleet of unpaid interns brought me several coffees as my hands bleed from my toils to bring such truth and beauty to the Vercel Turbopack's github README.

You are welcome

The "At least i am not working in angular" Primeagen

ThePrimeagen avatar Oct 27 '22 15:10 ThePrimeagen

@ThePrimeagen is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 27 '22 15:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Updated
examples-basic-web ⬜️ Ignored (Inspect) Oct 27, 2022 at 9:43PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Oct 27, 2022 at 9:43PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Oct 27, 2022 at 9:43PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Oct 27, 2022 at 9:43PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Oct 27, 2022 at 9:43PM (UTC)

vercel[bot] avatar Oct 27 '22 15:10 vercel[bot]

LGTM, nice work 👍

marcusziade avatar Oct 27 '22 15:10 marcusziade

SHIIIIIP IT

nexxeln avatar Oct 27 '22 15:10 nexxeln

LGTM!

t3ned avatar Oct 27 '22 15:10 t3ned

LGTM.

OlivierFortier avatar Oct 27 '22 15:10 OlivierFortier

most importantly that white space character was removed.

Caryyon avatar Oct 27 '22 15:10 Caryyon

LGTM, specially that space removal.

edr3x avatar Oct 27 '22 15:10 edr3x

Some good feedback already,

Fixed the "an" -> "a"

TheStartup never misses

ThePrimeagen avatar Oct 27 '22 15:10 ThePrimeagen

my manager was asking me for benchmark on this tool, this information should be enough to go in my report. :shipit:

piq9117 avatar Oct 27 '22 15:10 piq9117

LGTM!

AlonHor avatar Oct 27 '22 15:10 AlonHor

lgtm!

omar2205 avatar Oct 27 '22 15:10 omar2205

LGTM!

aymanesarrar avatar Oct 27 '22 15:10 aymanesarrar

LGTM! Ship iiiiitttt

Wankishh avatar Oct 27 '22 15:10 Wankishh

Looks G to M

npmaile avatar Oct 27 '22 15:10 npmaile

LGETM! OSS at its finest

marcelfahle avatar Oct 27 '22 15:10 marcelfahle

LGTM 👍

loczek avatar Oct 27 '22 15:10 loczek

LGTM!

WilliamWelsh avatar Oct 27 '22 15:10 WilliamWelsh

LGTM, send it!

rtrom avatar Oct 27 '22 15:10 rtrom

Ship it, a change i have been waiting for

Arjun31415 avatar Oct 27 '22 15:10 Arjun31415

LGTM, testing results show it was significantly faster with proposed commit.

mvaldes14 avatar Oct 27 '22 15:10 mvaldes14

LGTM!

ysanatomic avatar Oct 27 '22 15:10 ysanatomic

I was going to overlook turbo as "yet another" but this new description has opened my eyes, and I think I will reconsider...

ryanwinchester avatar Oct 27 '22 15:10 ryanwinchester

Wow, there's only one person in Open Source that could convince me to take a look at turbopack. Super excited to see @ThePrimeagen contributing to this project!

tjdevries avatar Oct 27 '22 15:10 tjdevries

LGTM

devgiri0082 avatar Oct 27 '22 15:10 devgiri0082

LGTM!

tbezman avatar Oct 27 '22 15:10 tbezman

my fav "Blazing Fast" meme, LGTM

zigang93 avatar Oct 27 '22 15:10 zigang93

LGTM

rauchg avatar Oct 27 '22 16:10 rauchg

LGTM

Andrew-Pynch avatar Oct 27 '22 16:10 Andrew-Pynch

LGTM

ikhattab avatar Oct 27 '22 16:10 ikhattab