turbo icon indicating copy to clipboard operation
turbo copied to clipboard

Update "Why Turbopack" docs section to be more clear in relation to tooling

Open timothyis opened this issue 3 years ago • 3 comments

Hi all! Congratulations on the release yesterday! 🎉

I was just reading this section about "Why Turbopack" and came across some wording that I think might be cleaner with this change.

It sounded a bit off to me that the first paragraph said "like Vite" and the second paragraph directly related to Vite alone, so I'm proposing that the wording relates to "Tooling frameworks like Vite", and then "those tooling frameworks", to directly relate the paragraphs.

timothyis avatar Oct 26 '22 07:10 timothyis

@timothyis is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 26 '22 07:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Updated
examples-basic-web ⬜️ Ignored (Inspect) Oct 26, 2022 at 7:43AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Oct 26, 2022 at 7:43AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Oct 26, 2022 at 7:43AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Oct 26, 2022 at 7:43AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Oct 26, 2022 at 7:43AM (UTC)

vercel[bot] avatar Oct 26 '22 07:10 vercel[bot]

Deferring to @mattpocock

chris-olszewski avatar Oct 26 '22 16:10 chris-olszewski

@timothyis Thanks for the contribution! I think the current wording is clear enough. It uses Vite as representative of Native ESM toolchains as a whole, which I feel it is.

mattpocock avatar Oct 26 '22 18:10 mattpocock

No problem @mattpocock, thanks for reviewing.

Just to be clear, the change I suggested wasn't to get rid of that representation, but just because I think the two paragraphs don't match with how they talk about the context of Vite and frameworks.

timothyis avatar Oct 26 '22 19:10 timothyis