Caching, but to tar files.

[nathanhammond]

So it's a bit more visible, here's the portion of the underlying cache work focused on tar file creation.

[vercel[bot]]

@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

[gsoltis]

General comment, and not a blocker on this, but using AbsoluteSystemPath is causing us to lose a lot of the type safety we might otherwise get. Calls to things like os.Open are going to be hard to track down in the future. We can't just search for .ToString(), since that also covers places where we do in fact want the string value, rather just as a means to get to the filesystem. Maybe in the meantime duplicate some of the fs wrappers from AbsolutePath?

[nathanhammond]

General comment, and not a blocker on this, but using AbsoluteSystemPath is causing us to lose a lot of the type safety we might otherwise get. Calls to things like os.Open are going to be hard to track down in the future. We can't just search for .ToString(), since that also covers places where we do in fact want the string value, rather just as a means to get to the filesystem. Maybe in the meantime duplicate some of the fs wrappers from AbsolutePath?

#2026 sets me up to address this. I'll note that there is a large chunk of this that is intentionally working with strings because we don't actually know anything about the input.

Here are some examples of UnsafeJoins in the existing tar behavior:

• https://github.com/vercel/turborepo/blob/8928b11306b42a0a31cb76b5560f7df014ee31dc/cli/internal/cache/cache_http.go#L254
• https://github.com/vercel/turborepo/blob/8928b11306b42a0a31cb76b5560f7df014ee31dc/cli/internal/cache/cache_http.go#L295
• https://github.com/vercel/turborepo/blob/8928b11306b42a0a31cb76b5560f7df014ee31dc/cli/internal/cache/cache_http.go#L301

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
turbo-site	✅ Ready (Inspect)	Visit Preview	Oct 6, 2022 at 5:53PM (UTC)

[nathanhammond]

Checkpoint, the only open items here:

• Is there a better option for than reflect for existence checks?
• SafeMkdirAll's perf optimization.

[gsoltis]

Lint error is a formatting issue with a comment. Going to force-merge if everything else passes and then submit a separate PR to fix it (or ignore it?)