turbo icon indicating copy to clipboard operation
turbo copied to clipboard

Turbo-specific changes to build containers

Open gsoltis opened this issue 3 years ago • 4 comments

  • Introduce some variables for owner and git repo
  • Remove a bunch of architectures that we aren't targeting
  • Add a turbo-cross container on top to hold pieces that are not go-specific. So far, this is node, but will likely be expanded in the future

gsoltis avatar Sep 12 '22 22:09 gsoltis

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Sep 30, 2022 at 5:21PM (UTC)

vercel[bot] avatar Sep 12 '22 22:09 vercel[bot]

I just noticed that the imported build is redistributing the macOS SDK, we should probably not be doing that.

nathanhammond avatar Sep 15 '22 17:09 nathanhammond

Re: the SDKs, I've added a note about the XCode license (copied from oxcross, where the SDKs are coming from). I'll check internally as well to see what the specific issue is.

gsoltis avatar Sep 15 '22 21:09 gsoltis

This is going to take some work to strip down the images for just linux and windows

gsoltis avatar Sep 21 '22 21:09 gsoltis

Dropped node install as well, since we can't standardize on this image, we'll standardize on the gh actions setup instead.

gsoltis avatar Sep 23 '22 20:09 gsoltis

Also note that we don't layer anything on top of the goreleaser image anymore, we've just removed things. So, we tag the final image over to turbo-cross instead of building a new one.

gsoltis avatar Sep 23 '22 20:09 gsoltis

Images built and pushed w/ latest commit

gsoltis avatar Sep 30 '22 17:09 gsoltis