turbo icon indicating copy to clipboard operation
turbo copied to clipboard

Add a new action to run create-turbo package tests in CI

Open mehulkar opened this issue 1 year ago • 2 comments

mehulkar avatar Aug 08 '22 22:08 mehulkar

@mehulkar is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 08 '22 22:08 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Aug 15, 2022 at 3:25PM (UTC)

vercel[bot] avatar Aug 10 '22 16:08 vercel[bot]

Some things we might want to consider adding, now or in the future

Good ideas. I think it makes sense to get these running first and add more as needed

are we going to test old and new yarn ("berry")?

I'd have to think about how to make this possible, since the CI setup (rather than the test case itself) is installing and activating the yarn/npm/etc.

mehulkar avatar Aug 12 '22 17:08 mehulkar

Test failure? Or is it flaky?

gsoltis avatar Aug 12 '22 23:08 gsoltis

Test failure? Or is it flaky?

I think they are flaky. Looks like it's the Go e2e ones, which shouldn't be affected by this PR.

cli:test: > make test-go
[26](https://github.com/vercel/turborepo/runs/7840795316?check_suite_focus=true#step:10:27)
cli:test: 
[27](https://github.com/vercel/turborepo/runs/7840795316?check_suite_focus=true#step:10:28)
cli:test: go test -race ./...

...[snipped]...

cli:test: Started
[56](https://github.com/vercel/turborepo/runs/7840795316?check_suite_focus=true#step:10:57)
cli:test: --- FAIL: TestStart (0.20s)
[57](https://github.com/vercel/turborepo/runs/7840795316?check_suite_focus=true#step:10:58)
cli:test:     child_test.go:159: process should have exited

mehulkar avatar Aug 15 '22 16:08 mehulkar

@mehulkar I think one of the js tests is also failing

gsoltis avatar Aug 15 '22 16:08 gsoltis

@mehulkar I think one of the js tests is also failing

npm install, et al are timing out, even at 50s timeout. Removed them from this PR, and will submit separately to isolate and add logging etc.

mehulkar avatar Aug 15 '22 17:08 mehulkar