turbo icon indicating copy to clipboard operation
turbo copied to clipboard

chore(example): upgrade Remix on kitchen sink example

Open ruisaraiva19 opened this issue 3 years ago • 8 comments

This updates the kitchen sink example Remix blog app to version ^1.6.5.

I boostraped a new Remix app via npx create-remix@latest and choose the Vercel deployment target with TypeScript. After that, I manually copied the files and made sure to still have the <CounterButton /> being rendered on the home page.

With version >=1.6.4, we can now use the watchPaths option in remix.config to watch for changes on the UI package and trigger a live reload in Remix dev server.

ruisaraiva19 avatar Apr 19 '22 13:04 ruisaraiva19

@ruisaraiva19 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 19 '22 13:04 vercel[bot]

Resolve conflicts

jaredpalmer avatar Apr 27 '22 13:04 jaredpalmer

Resolve conflicts

Fixed!

ruisaraiva19 avatar Apr 28 '22 07:04 ruisaraiva19

@ruisaraiva19 does this PR solves the issue that any changes in ui are not recognised in the Remix app on any file change (dev mode) https://github.com/vercel/turborepo/issues/1035?

dohomi avatar May 13 '22 03:05 dohomi

@ruisaraiva19 does this PR solves the issue that any changes in ui are not recognised in the Remix app on any file change (dev mode) #1035?

@dohomi I just pushed a commit with a patch to solve the issue on this example!

ruisaraiva19 avatar May 13 '22 08:05 ruisaraiva19

@ruisaraiva19 I see thanks for the example. I will wait until the patch is released

dohomi avatar May 18 '22 07:05 dohomi

Looks cool, thanks for the work here! :sparkling_heart:

tigerabrodi avatar Jul 28 '22 04:07 tigerabrodi

@dohomi I just pushed a commit updating Remix to version 1.6.5 where it has support for a watchPaths option for remix.config to watch paths other than the app folder. We don't need the patch that I did before anymore.

You can see here the specific line of configuration.

ruisaraiva19 avatar Jul 28 '22 07:07 ruisaraiva19

@ruisaraiva19 thanks for the work here - I can take a look at this today if this is in a good place for merge?

tknickman avatar Aug 24 '22 13:08 tknickman

@tknickman it should be ready to review

ruisaraiva19 avatar Aug 26 '22 15:08 ruisaraiva19

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 3:21PM (UTC)

vercel[bot] avatar Sep 12 '22 15:09 vercel[bot]

@tknickman the package-lock.json file is now removed.

ruisaraiva19 avatar Sep 13 '22 14:09 ruisaraiva19