swr icon indicating copy to clipboard operation
swr copied to clipboard

chore: refactor version bump script for improved readability and maintainability

Open Ayoub-Mabrouk opened this issue 1 year ago • 3 comments

This commit refactors the version bump script to enhance its readability and maintainability. The following changes have been made:

  • Consolidated environment variable extraction for cleaner code.
  • Simplified the bumpVersion function to use a more concise approach for logging or executing the command.
  • Streamlined the updateVersion function with improved logic and readability.

These improvements aim to make the script easier to understand and modify in the future.

Ayoub-Mabrouk avatar Sep 15 '24 18:09 Ayoub-Mabrouk

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codesandbox-ci[bot] avatar Sep 15 '24 18:09 codesandbox-ci[bot]

You don't need semicolons in JS/TS code anymore, why?

eshimischi avatar Dec 14 '24 20:12 eshimischi

Won't the destructuring of ,process.env, be a problem for those that use DefinePlugin from webpack? Typically the process.env.FOO is inlined as is.

icyJoseph avatar Dec 14 '24 21:12 icyJoseph