sveltekit-commerce icon indicating copy to clipboard operation
sveltekit-commerce copied to clipboard

Fix double scroll bar in Windows 10

Open hyunbinseo opened this issue 2 years ago • 4 comments

Double scroll bar (overflow: scroll) Screenshot_20220913-162228_chrome

Single scroll bar Screenshot_20220913-162232_chrome

hyunbinseo avatar Sep 13 '22 07:09 hyunbinseo

@hyunbinseo is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 13 '22 07:09 vercel[bot]

Oh shoot, there's a merge conflict - could you update please?

leerob avatar Nov 17 '22 02:11 leerob

Sorry for the slow PR. Had to get a Windows 10 device to double check.

Note that there is an existing bug in the original carousel code.

- <div class="slider relative w-full overflow-scroll bg-light">
+ <div class="slider relative w-full overflow-x-scroll bg-light">

Did not fix the bug, and simply changed the .overflow-scroll to .overflow-x-scroll.


Reproduction: once the animation starts, quickly start to the end and wait.

https://github.com/vercel/sveltekit-commerce/assets/47051820/8a27af9a-6706-45a6-b3ce-da01f17053e6

Changed the animation duration to 10s for demonstration.

hyunbinseo avatar Jul 26 '23 09:07 hyunbinseo

@leerob Could this be merged?

Edit: My bad. It was approved back in November.

hyunbinseo avatar Sep 07 '23 12:09 hyunbinseo