release icon indicating copy to clipboard operation
release copied to clipboard

Can't release if there's only 1 commit since last tag

Open aesopwolf opened this issue 7 years ago • 3 comments

I end up with the error Error! No changes happened since the last release. if I have only 1 commit since the last tag.

Seems like the following code might be the issue https://github.com/zeit/release/blob/master/lib/commits.js#L22

  if (commit.hash === release.hash) {
    return
  }

aesopwolf avatar Jun 30 '17 22:06 aesopwolf

It seems like this was added added as feature?

#73 Detect and ignore tag commits?

I don't know if they would revert from this as the above issue shows that this is an intended behaviour.

I don't think this fits our workflow as we do not create extra commits for tags but we'll just have to implement it on our fork.

omerfarukyilmaz avatar Jul 17 '17 04:07 omerfarukyilmaz

This same bug also is biting me during normal releases since it causes the tagged commit to be ignored (so I'm short a commit in my release log).

It would be nice to document this expectation/assumption -- tags are expected to have their own commit (for example).

Even nicer would be a config option exposed to the end user to change this behavior.

@leo Would you be open to a PR that adds this feature? Perhaps just a CLI flag?

aesopwolf avatar Aug 29 '17 23:08 aesopwolf

Same here :/

felipefialho avatar Sep 11 '17 18:09 felipefialho