reactions icon indicating copy to clipboard operation
reactions copied to clipboard

Add Your Reaction Here

Open chibicode opened this issue 5 years ago • 36 comments

Reactions on this comment will be reflected on https://reactions-demo.vercel.app/

This uses Next.js’s Incremental Static Regeneration feature which is supported out of the box by Vercel’s Edge Network.

chibicode avatar May 19 '20 16:05 chibicode

Data Fetching Code:

https://github.com/chibicode/reactions/blob/42e08310fdbdd370a366bc6cacd043e2636c10c6/pages/index.js#L3-L60

chibicode avatar May 19 '20 18:05 chibicode

This is so cool!

martinseanhunt avatar Aug 04 '20 09:08 martinseanhunt

Damn.

anteeek avatar Aug 05 '20 15:08 anteeek

Exactly what I needed, thanks!

Nases avatar Aug 07 '20 08:08 Nases

Are you sure its revalidation is done every 1 second or the Github gets updated values after a delay? I get the updated values on the page after a couple of minutes.

amir-gorji avatar Sep 30 '20 13:09 amir-gorji

Interstingly it updated the first time after a second and a second time after some minutes..

pungggi avatar Oct 06 '20 20:10 pungggi

page is not refreshing after1 sec! updated only after few mins..

msreekm avatar Nov 02 '20 05:11 msreekm

page is not refreshing after1 sec! updated only after few mins..

yes, I tested and same issue with you

nghiepnguyen520 avatar Nov 23 '20 01:11 nghiepnguyen520

So the first request that trigger the incremental build will alway get the stale data?

mdovn avatar Dec 13 '20 15:12 mdovn

It's fast and absolutely static.

thisisbintang avatar Dec 18 '20 11:12 thisisbintang

Is it expected to be updated alone every 1 second without refreshing ? Because I wait 20 Minutes just watching if it will update the information and still not updating

Abdalhadi-Jarad avatar Dec 28 '20 10:12 Abdalhadi-Jarad

@Abdalhadi-Jarad no, since it's a static page you have a refresh a couple of times to regenerate the page.

cobrexus avatar Jan 07 '21 20:01 cobrexus

Just in case anyone wants to know how this demo behaves with different timeouts, I made a fork and you can see it on https://reactions.jrayo.vercel.app/

jrayo avatar Jan 18 '21 20:01 jrayo

Is it expected to be updated alone every 1 second without refreshing ? Because I wait 20 Minutes just watching if it will update the information and still not updating

zhangfaliang avatar Mar 07 '21 07:03 zhangfaliang

@zhangfaliang no, since it's a static page you have a refresh a couple of times to regenerate the page.

cobrexus avatar Mar 07 '21 13:03 cobrexus

this has got to be a record :D

coderinblack08 avatar Mar 17 '21 04:03 coderinblack08

hello github

Slipromise avatar Apr 23 '21 09:04 Slipromise

hello, hello, yes i think so

javakian avatar May 24 '21 00:05 javakian

Great, but I am a little bit confused, doesn't this feature just beg for custom bots to poll the static sites periodically, since the first page served after timeout is stale?

zed-b avatar Jun 16 '21 09:06 zed-b

Great, but I am a little bit confused, doesn't this feature just beg for custom bots to poll the static sites periodically, since the first page served after timeout is stale?

@zed-b the page served whilst the timeout is stale displayed a loading or skeleton or blank page whilst the new page is being regenerated.

cobrexus avatar Jun 16 '21 13:06 cobrexus

@chibicode @leerob I think I am missing something. I modified the code (see gist) to print out a given timestamp passed through getStaticProps. I would expect that the page should regenerate every minute, and hence my timestamp shouldn't change during refresh. However, I noticed that when I refresh the page, the timestamp is always updated. thoughts? 🤔

Update: I just realized that during yarn dev getStaticPropstriggers all the time during refresh, but when running fromyarn start`, getStaticProps behaves as it should!

mkotsollaris avatar Apr 15 '22 17:04 mkotsollaris

Screenshot 2022-11-25 at 9 22 44 AM

Screenshot 2022-11-25 at 9 23 07 AM

Screenshot 2022-11-25 at 9 23 23 AM

GBR-422777 avatar Nov 25 '22 08:11 GBR-422777

Screen Shot 2023-01-05 at 12 00 16 PM Screen Shot 2023-01-05 at 12 00 32 PM

Does anybody know why my reactions are not up to date? I visited the demo app a while ago and it worked. Yesterday I visited it again and noticed the values have not changed since then.

JoshuaR503 avatar Jan 05 '23 20:01 JoshuaR503

Still not fixed. CleanShot 2023-01-18 at 21 20 43@2x

Levent0z avatar Jan 19 '23 05:01 Levent0z

Our GitHub personal access token expired. We'll get a new one added. In the meantime, you can see a similar demo here: https://on-demand-isr.vercel.app/

leerob avatar Jan 20 '23 05:01 leerob

Hi, do we have updates on renewing the GitHub personal access token?

relaxedleaf avatar Feb 18 '23 04:02 relaxedleaf

hi

mnm1984 avatar Feb 28 '23 18:02 mnm1984

raa

htrigoso avatar Mar 03 '23 20:03 htrigoso

sdasdasdasdasdsada

pauloalmeida19 avatar Mar 26 '23 22:03 pauloalmeida19

Really? Why it is STILL not worked?

Peter-developer01 avatar Apr 24 '23 16:04 Peter-developer01