react-tweet icon indicating copy to clipboard operation
react-tweet copied to clipboard

fix: set `isLoading: false` when id is `undefined`

Open TatsuyaYamamoto opened this issue 9 months ago • 4 comments

I can't tell if this PR is a fix or a feat.


If id is undefined, useTweet return isLoading: true. However, I think useTweet should return isLoading: false because SWR cannot without id. For this reason, I propose to change a behavior of useTweet.

If this change is reasonable, a behavior of <Tweet /> may also need to be changed.

https://github.com/vercel/react-tweet/blob/main/packages/react-tweet/src/swr.tsx

TatsuyaYamamoto avatar Mar 21 '25 14:03 TatsuyaYamamoto

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-tweet-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 2:45pm
react-tweet-custom-tweet-dub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 2:45pm
react-tweet-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 2:45pm
react-tweet-vite-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 2:45pm

vercel[bot] avatar Mar 21 '25 14:03 vercel[bot]

@TatsuyaYamamoto is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 21 '25 14:03 vercel[bot]

@TatsuyaYamamoto The change looks reasonable to me, finish the change and I'll merge it!

lfades avatar Sep 21 '25 14:09 lfades