pkg icon indicating copy to clipboard operation
pkg copied to clipboard

fix: add force flag to codesign to avoid already signed error

Open brianunlam opened this issue 3 years ago • 2 comments

It adds force flag to codesign utility to avoid errors when an existing sign prevents a new sign. It solves https://github.com/vercel/pkg/issues/1574

brianunlam avatar Sep 14 '22 11:09 brianunlam

Hey, anything I can do to help get this merged in?

lattwood avatar Sep 20 '22 17:09 lattwood

I would like to know @jesec opinion about this as he has more experience then me regarding mac OS things, dunno if that flag could break older OS?

robertsLando avatar Sep 21 '22 06:09 robertsLando

The flag is just a force flag, it is very old and compatible with other os

bro4all avatar Oct 13 '22 01:10 bro4all

The flag is compatible and It doesn't take any wrong effects.

When signing, causes codesign to replace any existing signature on the path(s) given. Without this option, existing signatures will not be replaced, and the signing operation fails. from man codesign :D

134130 avatar Nov 06 '22 05:11 134130

@jesec ping

robertsLando avatar Nov 07 '22 09:11 robertsLando

Bump

ryanblock avatar Nov 30 '22 19:11 ryanblock

This pull-request is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this pull-request entirely you can add the no-stale label

github-actions[bot] avatar Mar 01 '23 00:03 github-actions[bot]

@jesec bump again

ryanblock avatar Mar 01 '23 01:03 ryanblock

FYI @robertsLando seems like the failed run is a non issue.

ryanblock avatar Mar 02 '23 15:03 ryanblock

@brianunlam @robertsLando The auto-merge is not available since node16's prettier is failing. The prettier is warning 'print-width' is over.

Would you resolve this issue? I don't have any permission to commit this. Simple command: prettier -w lib/mach-o.ts

134130 avatar Mar 06 '23 00:03 134130

@robertsLando can a release version be tagged with this change?

Mikescops avatar Mar 06 '23 14:03 Mikescops

@Mikescops Need to speak with @leerob and @baparham about that

robertsLando avatar Mar 06 '23 14:03 robertsLando