pkg icon indicating copy to clipboard operation
pkg copied to clipboard

Can't bundle ncc output.

Open FrontMage opened this issue 2 years ago • 2 comments

What version of pkg are you using?

5.8.0

What version of Node.js are you using?

17.9.0

What operating system are you using?

macOS

What CPU architecture are you using?

Apple M1

What Node versions, OSs and CPU architectures are you building for?

node14-linux-x64

Describe the Bug

Can't bundle the output of ncc, I was trying to bundle everything with ncc first then pkg them together.

> Error! Invalid left-hand side in assignment expression (6717:19)

Expected Behavior

That ncc output can be bundled by pkg.

To Reproduce

Any node js application will do, just try ncc first then try to bundle the output.

FrontMage avatar Aug 10 '22 01:08 FrontMage

ncc outputs esm modules AFAIK, you should use an older ncc version or a boundler that converts them to commonjs as esm are not supported by pkg yet

robertsLando avatar Aug 10 '22 06:08 robertsLando

@robertsLando Thx! I'll try install the older version

FrontMage avatar Aug 15 '22 04:08 FrontMage

This issue is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this issue entirely you can add the no-stale label

github-actions[bot] avatar Nov 14 '22 00:11 github-actions[bot]

This issue is now closed due to inactivity, you can of course reopen or reference this issue if you see fit.

github-actions[bot] avatar Nov 19 '22 00:11 github-actions[bot]