pkg icon indicating copy to clipboard operation
pkg copied to clipboard

Recursive reference without node

Open aboe026 opened this issue 3 years ago • 4 comments

Allow the pkg binary to be called within itself without adjusting process.argv as if it were a node process.

aboe026 avatar Jun 14 '22 22:06 aboe026

I believe this is somewhat related to https://github.com/vercel/pkg/issues/376

aboe026 avatar Jun 14 '22 22:06 aboe026

Also some guidance on tests would be helpful. For instance, I'm not sure what the test numbers mean, and they also seems to contain a mix of PR numbers and issue numbers.

aboe026 avatar Jun 17 '22 14:06 aboe026

This pull-request is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this pull-request entirely you can add the no-stale label

github-actions[bot] avatar Sep 16 '22 00:09 github-actions[bot]

This pull-request is now closed due to inactivity, you can of course reopen or reference this pull-request if you see fit.

github-actions[bot] avatar Sep 21 '22 00:09 github-actions[bot]

This pull-request is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this pull-request entirely you can add the no-stale label

github-actions[bot] avatar Dec 28 '22 00:12 github-actions[bot]

Any update on this?

jcs090218 avatar Jan 09 '23 17:01 jcs090218

Seems like the error on the failing badge CI / test (12.x, windows-latest) (pull_request) is

> Error! Error: EPERM: operation not permitted, open 'D:\a\pkg\pkg\test\test-50-public-packages\test-output.exe'
> node D:\a\pkg\pkg\lib-es5\bin.js --public-packages=* --target node14 --output ./test-output.exe ./test-x-index.js
> Status 2, expected 0
> node main.js node14

Not sure how my changes would have caused that regression, perhaps a flaky test? I'd also appreciate some guidance on the test structure and how they are written, they do not seem to be in any test framework that I've worked with in the past (jest, mocha, tape, etc)

aboe026 avatar Jan 09 '23 18:01 aboe026

This pull-request is stale because it has been open 90 days with no activity. Remove the stale label or comment or this will be closed in 5 days. To ignore this pull-request entirely you can add the no-stale label

github-actions[bot] avatar Apr 10 '23 00:04 github-actions[bot]

This pull-request is now closed due to inactivity, you can of course reopen or reference this pull-request if you see fit.

github-actions[bot] avatar Apr 17 '23 00:04 github-actions[bot]

Can this please be reopened?

aboe026 avatar Apr 17 '23 00:04 aboe026