nft icon indicating copy to clipboard operation
nft copied to clipboard

Add support for `@datadog/pprof`

Open austinwoon opened this issue 1 year ago • 2 comments

When building with output: standalone, @datadog/pprof prebuilds gets excluded as the current AST logic introduced in https://github.com/vercel/nft/issues/391 does not handle the case where imports are assigned to a const.

See @datadog/pprof codebase here on how they assign the CJS import of node-gyp-build to a variable, that way we cannot resolve the name to node-gyp-build just by inferring the AST node's first argument

Suggested solution

Instead of modifying the conditionals to handle this case like in #391, just add a special case for @datadog/pprof to include the prebuilds folder. I have a fix up and will discuss the alternative in more detail here

austinwoon avatar Apr 18 '24 14:04 austinwoon

Is there any progress at all? We have same issue

ragingwind avatar Apr 26 '24 03:04 ragingwind

Is there any progress at all? We have same issue

The PR is up awaiting review. You could comment there just to nudge it towards getting merged

austinwoon avatar Apr 26 '24 05:04 austinwoon