nextjs-subscription-payments icon indicating copy to clipboard operation
nextjs-subscription-payments copied to clipboard

feat(account page): update user full name

Open irvile opened this issue 3 years ago • 1 comments

Feature

This feature was request in this issue #28

https://user-images.githubusercontent.com/1596614/160174916-ee6d9b5a-25da-47f3-9cfb-c3e72625961e.mov

Closes #28

Could you review this PR? @leerob @thorwebdev

irvile avatar Mar 25 '22 17:03 irvile

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/nextjs-subscription-payments/Xs8hGL2mRPBJ9Ap8eYt2RnqSPeCY
✅ Preview: https://nextjs-subscription-paymen-git-d87a4e-vercel-solutions-vtest314.vercel.app

vercel[bot] avatar Mar 25 '22 17:03 vercel[bot]

Thanks @irvile, would also love it if this change could be merged :)

Thanks again to the team responsible for this great starter!

tdeitz avatar Nov 10 '22 12:11 tdeitz

Actually @irvile, I do get a typescript error with this function:

const updateUserFullname = async (userId: string, newFullName: string) => {
    const { data, error } = await supabase
      .from<UserDetails>('users')
      .update({ full_name: newFullName })
      .match({ id: userId });

    if (data) {
      setUserDetails(data[0]);
    }

    return error;
  };

No overload expects 1 type arguments, but overloads do exist that expect either 0 or 2 type arguments.

Any ideas how to resolve this?

tdeitz avatar Nov 10 '22 13:11 tdeitz

Hi @tdeitz , I dont get this error. This error show when call a function and pass it a parameter that doesn't match any of its specified overloads.

I will update my branch to solve these conflicts, they updated supabase dependencies. Hope help you.

irvile avatar Nov 10 '22 13:11 irvile

@irvile thanks very much for the reply. I'm a Typescript amateur (at best), so my debugging ability is pretty limited for now. Appreciate the branch update, thanks again :)

tdeitz avatar Nov 10 '22 13:11 tdeitz

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-subscription-payments ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 2:39PM (UTC)

vercel[bot] avatar Nov 10 '22 14:11 vercel[bot]

@tdeitz done! This error that you commented show up because the new version of supabase v2, don't accept Type as the last version( supabase.from<UserDetails>)

Welcome! Its a pleasure help. Let me know if you have any other issue. I tested right now and supabase and stripe works fine.

irvile avatar Nov 10 '22 14:11 irvile

@irvile thanks so much, really appreciate your efforts, can't wait to have a look! :)

tdeitz avatar Nov 11 '22 03:11 tdeitz

Hello, is there any blocker for this PR to be merged ?

adrientiburce avatar Feb 13 '23 23:02 adrientiburce