next.js icon indicating copy to clipboard operation
next.js copied to clipboard

Docs: search dialog background transition bug

Open clicktodev opened this issue 11 months ago • 5 comments

What is the documentation issue?

  1. open the search dialog
  2. dialog background goes black then suddenly transparent

Is there any context that might help us understand?

https://github.com/user-attachments/assets/3957dcc6-9002-49e1-aa02-73a60fc4eca2

Does the docs page already exist? Please link to it.

https://nextjs.org/docs/app/api-reference/config/next-config-js/typedRoutes

clicktodev avatar Feb 05 '25 15:02 clicktodev

We could not detect a valid reproduction link. Make sure to follow the bug report template carefully.

Why was this issue closed?

To be able to investigate, we need access to a reproduction to identify what triggered the issue. We need a link to a public GitHub repository (template for App Router, template for Pages Router), but you can also use these templates: CodeSandbox: App Router or CodeSandbox: Pages Router.

The bug template that you filled out has a section called "Link to the code that reproduces this issue", which is where you should provide the link to the reproduction.

  • If you did not provide a link or the link you provided is not valid, we will close the issue.
  • If you provide a link to a private repository, we will close the issue.
  • If you provide a link to a repository but not in the correct section, we will close the issue.

What should I do?

Depending on the reason the issue was closed, you can do the following:

  • If you did not provide a link, please open a new issue with a link to a reproduction.
  • If you provided a link to a private repository, please open a new issue with a link to a public repository.
  • If you provided a link to a repository but not in the correct section, please open a new issue with a link to a reproduction in the correct section.

In general, assume that we should not go through a lengthy onboarding process at your company code only to be able to verify an issue.

My repository is private and cannot make it public

In most cases, a private repo will not be a sufficient minimal reproduction, as this codebase might contain a lot of unrelated parts that would make our investigation take longer. Please do not make it public. Instead, create a new repository using the templates above, adding the relevant code to reproduce the issue. Common things to look out for:

  • Remove any code that is not related to the issue. (pages, API routes, components, etc.)
  • Remove any dependencies that are not related to the issue.
  • Remove any third-party service that would require us to sign up for an account to reproduce the issue.
  • Remove any environment variables that are not related to the issue.
  • Remove private packages that we do not have access to.
  • If the issue is not related to a monorepo specifically, try to reproduce the issue without a complex monorepo setup

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps by opening a new issue.

I think my reproduction is good enough, why aren't you looking into it quickly?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

github-actions[bot] avatar Feb 05 '25 15:02 github-actions[bot]

Hi,

I think this has been fixed. If I slowdown the animation I can see that the transparency transitions ok.

https://github.com/user-attachments/assets/0c0ce0c5-1d47-4c26-8e8d-32e6ebbbffd3

icyJoseph avatar Jun 13 '25 11:06 icyJoseph

I'm getting layout shifts on the closing animation on windows

https://github.com/user-attachments/assets/610ddd7f-fe4e-4eb2-9728-6cac4ea39567

clicktodev avatar Jun 13 '25 13:06 clicktodev

Yeah I see that, scrollbar blindness has happened. Let me see if I can quickly patch this.

icyJoseph avatar Jun 13 '25 13:06 icyJoseph

perhaps take a look at the shadcn and headlessui dialog implementations, they don't seem to suffer from this issue

clicktodev avatar Jun 15 '25 02:06 clicktodev

Hi thanks for the feedback, you know as production code grows, there's need to accommodate various other features, and that lead to this behavior sneaking in, I've fixed it in Chrome/Safari, but I am still having a bit of a quirk I want to sort out in FF.

icyJoseph avatar Jun 16 '25 07:06 icyJoseph

Hi, we had some pipeline issues, but this is fixed now :)

icyJoseph avatar Jun 18 '25 12:06 icyJoseph

Looks like there's no closing animation now :(

clicktodev avatar Jun 18 '25 12:06 clicktodev

Right, I aligned with other docs we have, but since I got to merge the FF solution, I think I can bring back the fade out.

icyJoseph avatar Jun 18 '25 13:06 icyJoseph

looks like the turborepo docs have working exit animations and no layout shifts

clicktodev avatar Jun 18 '25 14:06 clicktodev

Hi, I think we fixed this last week, didn't we?

icyJoseph avatar Jun 23 '25 07:06 icyJoseph

Lgtm good work 💯

clicktodev avatar Jun 23 '25 08:06 clicktodev

Great! Thanks for the attention to detail. I'll go ahead an close the issue.

icyJoseph avatar Jun 23 '25 08:06 icyJoseph

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

github-actions[bot] avatar Jul 07 '25 12:07 github-actions[bot]