next.js icon indicating copy to clipboard operation
next.js copied to clipboard

normalize page path before checking for cached manifest in webpack

Open AbhiShake1 opened this issue 1 year ago • 1 comments

What?

this should fix index route not loading due to the client reference manifest being generated in index/index/ but we were expecting it in index/

Why?

when we normalize the page path before writing manifest and other assets, we see this behavior: / -> /index /index -> /index/index

How?

by normalizing the static page path, we now check for the manifest in index/index folder instead of index/ folder which fixes the issue

Closes NEXT- Fixes #69061

AbhiShake1 avatar Aug 26 '24 04:08 AbhiShake1

Allow CI Workflow Run

  • [ ] approve CI run for commit: cb0904f3079ecbcfee8740207b9d5604af4229a1

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

ijjk avatar Aug 26 '24 04:08 ijjk

Hi, could you please add a test case for this, potentially in https://github.com/vercel/next.js/tree/canary/test/e2e/app-dir/app

Sorry i was afk for a long time. I see another pr doing the same thing so closing this

AbhiShake1 avatar Dec 18 '24 03:12 AbhiShake1