next.js icon indicating copy to clipboard operation
next.js copied to clipboard

fix(next-swc): always set `useWasmBinary` based on config in `loadBindings` - fixes #62059

Open obiwac opened this issue 1 year ago • 1 comments

Fixes #62059

Currently, the experimental.useWasmBinary option is ignored when doing a next build, because SWC transpilation never sets the useWasmBinary parameter in loadBindings. I tried passing the option everywhere loadBindings is called but this was getting very cumbersome so I opted to read the option at the top of loadBindings, and, if it's set, set useWasmBinary to true.

I don't know if there's a better way to load the options for this, and I'll gladly change this is there is.

Another related issue which prevented this option from working has already been fixed in https://github.com/vercel/next.js/pull/65633.

obiwac avatar Jul 03 '24 12:07 obiwac

Allow CI Workflow Run

  • [ ] approve CI run for commit: 2a745256abd16016cc60847bc08122877c80c34c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

ijjk avatar Jul 03 '24 12:07 ijjk