next.js icon indicating copy to clipboard operation
next.js copied to clipboard
Published 3 weeks ago • verified publisher icon vercel

fix(next): added new error info in next/link component.

Open zhyd1997 opened this issue 1 year ago • 2 comments

Actually it's not dynamic link:

Screenshot 2024-05-14 at 15 17 22

Will save much time if it's more clear! :(

zhyd1997 avatar May 14 '24 11:05 zhyd1997

Allow CI Workflow Run

  • [ ] approve CI run for commit: ba9cd3f87f5e9e8978b3b9c881b16f418cf4c1d8

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

ijjk avatar May 14 '24 11:05 ijjk

Hi @devjiwonchoi

Thanks for your review.

  1. the 2nd some method is needed, because it can not combined with another one for different error handling.
  2. the object link happens when the <a> has an object href <page route> is clicked. So it's not easy to setup this test case in this file: https://github.com/vercel/next.js/blob/canary/test/e2e/app-dir/dynamic-href/dynamic-href.test.ts

zhyd1997 avatar Jun 27 '24 14:06 zhyd1997