next.js icon indicating copy to clipboard operation
next.js copied to clipboard

refactor(cli): refactor cli to commander

Open samcx opened this issue 1 year ago • 2 comments

Changes

...

Description

...

samcx avatar Feb 09 '24 21:02 samcx

Failing test suites

Commit: 16d600a6fa89f57120d24631598a7b874784765a

TURBOPACK=1 pnpm test test/integration/cli/test/index.test.js (turbopack)

  • CLI Usage > dev > NODE_OPTIONS='--inspect'
Expand output

● CLI Usage › dev › NODE_OPTIONS='--inspect'

TIMED OUT: /Debugger listening on/

Starting inspector on 127.0.0.1:9229 failed: address already in use
Starting inspector on 127.0.0.1:9230 failed: address already in use


undefined

  636 |
  637 |   if (hardError) {
> 638 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  639 |   }
  640 |   return false
  641 | }

  at check (lib/next-test-utils.ts:638:11)
  at Object.<anonymous> (integration/cli/test/index.test.js:545:9)

Read more about building and testing Next.js in contributing.md.

pnpm test-start test/e2e/app-dir/app/experimental-compile.test.ts (PPR)

  • app dir - basic > should provide query for getStaticProps page correctly
Expand output

● app dir - basic › should provide query for getStaticProps page correctly

expect(received).toEqual(expected) // deep equality

- Expected  - 3
+ Received  + 1

- Object {
-   "hello": "world",
- }
+ Object {}

  38 |
  39 |         const $ = cheerio.load(await res.text())
> 40 |         expect(JSON.parse($('#query').text())).toEqual({ hello: 'world' })
     |                                                ^
  41 |       })
  42 |     }
  43 |

  at Object.toEqual (e2e/app-dir/app/index.test.ts:40:48)

Read more about building and testing Next.js in contributing.md.

ijjk avatar Feb 16 '24 02:02 ijjk

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js sam/cli/commander Change
buildDuration 13.8s 13.8s N/A
buildDurationCached 7.5s 6.3s N/A
nodeModulesSize 197 MB 197 MB ⚠️ +59 kB
nextStartRea..uration (ms) 409ms 415ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sam/cli/commander Change
2453-HASH.js gzip 30.2 kB 30.2 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 45.4 kB 45.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sam/cli/commander Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sam/cli/commander Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.56 kB 6.56 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sam/cli/commander Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sam/cli/commander Change
index.html gzip 529 B 529 B
link.html gzip 542 B 542 B
withRouter.html gzip 524 B 523 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sam/cli/commander Change
edge-ssr.js gzip 95 kB 95 kB N/A
page.js gzip 3.08 kB 3.08 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sam/cli/commander Change
middleware-b..fest.js gzip 623 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js sam/cli/commander Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.7 kB 96.7 kB
app-page-tur..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 92.9 kB 92.9 kB
app-page.run...dev.js gzip 150 kB 150 kB
app-page.run..prod.js gzip 91.4 kB 91.4 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 20.9 kB 20.9 kB
app-route.ru..prod.js gzip 14.7 kB 14.7 kB
pages-api-tu..prod.js gzip 9.51 kB 9.51 kB
pages-api.ru...dev.js gzip 9.79 kB 9.79 kB
pages-api.ru..prod.js gzip 9.51 kB 9.51 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 23 kB 23 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.6 kB 50.6 kB
Overall change 950 kB 950 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sam/cli/commander Change
0.pack gzip 1.56 MB 1.56 MB ⚠️ +753 B
index.pack gzip 105 kB 105 kB N/A
Overall change 1.56 MB 1.56 MB ⚠️ +753 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: b1458b868a16ad9af362579902f84600d72787c5

ijjk avatar Feb 18 '24 00:02 ijjk