next.js icon indicating copy to clipboard operation
next.js copied to clipboard

Use full snapshot for redboxsource

Open timneutkens opened this issue 5 months ago • 3 comments

What?

Follow-up for #61369, updates the snapshots.

  • shows an overlay for a server-side error -- Somehow this stack line mentions (0:54) but it doesn't look correct. Maybe related to the "use client"?

The others are all still failing, some result in null so that still has to be fixed so I copied the snapshot from the webpack side so that they'll still fail.

Closes NEXT-2301

timneutkens avatar Jan 30 '24 15:01 timneutkens

  • #61394 Graphite 👈
  • canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

timneutkens avatar Jan 30 '24 15:01 timneutkens

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 01-30-Use_full_snapshot_for_redboxsource Change
buildDuration 11.6s 11.5s N/A
buildDurationCached 6.1s 5.2s N/A
nodeModulesSize 200 MB 200 MB
nextStartRea..uration (ms) 428ms 424ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-30-Use_full_snapshot_for_redboxsource Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.9 kB 29.9 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 238 B 239 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-30-Use_full_snapshot_for_redboxsource Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 01-30-Use_full_snapshot_for_redboxsource Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 502 B
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 608 B 608 B
Client Build Manifests
vercel/next.js canary vercel/next.js 01-30-Use_full_snapshot_for_redboxsource Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-30-Use_full_snapshot_for_redboxsource Change
index.html gzip 527 B 526 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 523 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-30-Use_full_snapshot_for_redboxsource Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 150 kB 150 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-30-Use_full_snapshot_for_redboxsource Change
middleware-b..fest.js gzip 626 B 624 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 37.6 kB 37.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary vercel/next.js 01-30-Use_full_snapshot_for_redboxsource Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 95.8 kB 95.8 kB
app-page-tur..prod.js gzip 96.4 kB 96.4 kB
app-page-tur..prod.js gzip 91 kB 91 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.3 kB 90.3 kB
app-route-ex...dev.js gzip 22.2 kB 22.2 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.5 kB 14.5 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.5 kB 14.5 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 933 kB 933 kB
Commit: 89df9468762aa0677de211b2a7db0c508eadee30

ijjk avatar Jan 30 '24 15:01 ijjk

Failing test suites

Commit: 89df9468762aa0677de211b2a7db0c508eadee30

pnpm test-dev test/development/app-hmr/hmr.test.ts (PPR)

  • app-dir-hmr > filesystem changes > should not break when renaming a folder
Expand output

● app-dir-hmr › filesystem changes › should not break when renaming a folder

TIMED OUT: success

undefined

Error: elementHandle.innerText: Element is not attached to the DOM

  636 |
  637 |   if (hardError) {
> 638 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  639 |   }
  640 |   return false
  641 | }

  at check (lib/next-test-utils.ts:638:11)
  at Object.<anonymous> (development/app-hmr/hmr.test.ts:44:11)

Read more about building and testing Next.js in contributing.md.

ijjk avatar Feb 01 '24 17:02 ijjk