next.js icon indicating copy to clipboard operation
next.js copied to clipboard

Published 20 hours ago • verified publisher icon vercel

fix: multi zone hmr

Open teovillanueva opened this issue 2 years ago • 8 comments

Bug

  • [x] Related issues linked using fixes #32634

teovillanueva avatar Jul 08 '22 13:07 teovillanueva

Hey! First time contributing to next.js 😊 If there is something missing let me know and I can work on it!

teovillanueva avatar Jul 08 '22 13:07 teovillanueva

We were having exactly this problem in our company, great solution!

ataschz avatar Jul 08 '22 14:07 ataschz

Hey, I don't mean to bother any of the reviewers, I guess you guys are all really occupied. Please if anyone can review this it would be great :) Thanks!

EDIT: Maybe Im a little bit anxious, but I really don't know whats the average time for a new contributor to get a review 😅

teovillanueva avatar Jul 19 '22 22:07 teovillanueva

Would be good to see this merged soon. We have the same issue with multizones and we can't upgrade to version 12 😢

sioquim avatar Aug 01 '22 21:08 sioquim

We are in the same boat. Would love to see this released

filipe-gomes avatar Aug 01 '22 22:08 filipe-gomes

🙃

teovillanueva avatar Aug 06 '22 13:08 teovillanueva

So the problem with not allowing something like this through is that you advertise multi zones which is awesome except you can't enjoy the HMR features cause the websocket requests can't be proxied "out-of-the-box". If you decide to go with this route, which is totally fine, I recommend on your docs to add a side note saying that HMR doesn't work and a code snippet showing the workaround using a custom server.

rszemplinski avatar Aug 09 '22 22:08 rszemplinski

Is it possible to let the user handle websocket requests inside middleware in the future?

rszemplinski avatar Aug 09 '22 22:08 rszemplinski