next.js icon indicating copy to clipboard operation
next.js copied to clipboard

Add dotCMS example

Open fmontes opened this issue 2 years ago • 3 comments

This adds a new example under cms-dotcms/. Is a general-purpose example that should allow developers to undestand how to use next.js with dotCMS apis.

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [x] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have helpful link attached, see contributing.md

Documentation / Examples

  • [x] Make sure the linting passes by running pnpm lint
  • [x] The examples guidelines are followed from our contributing doc

fmontes avatar Jun 30 '22 19:06 fmontes

Make sure linting is run through the directory. (you can use pnpm lint-fix)

balazsorban44 avatar Jul 11 '22 12:07 balazsorban44

Hi @balazsorban44 am I missing something here?

fmontes avatar Aug 07 '22 02:08 fmontes

Thanks, added some suggestions. Could we convert this to TypeScript also?

Please have a read of the guidelines: https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples

Hello, this is done.

fmontes avatar Sep 01 '22 23:09 fmontes

Hello @balazsorban44! I hope you are doing well. Thanks for your last feedback. I think we have already fixed everything required in the guidelines. When you have time, your feedback would be appreciated!

rjvelazco avatar Sep 28 '22 15:09 rjvelazco

~@fmontes please make sure that you allow contributors to edit this PR, so our bot can merge this!~

Update

Turns out it's because of this: https://github.com/orgs/community/discussions/5634

The GitHub UI says there are merge conflicts, but I am not able to see them. Can you fix those? :pray:

balazsorban44 avatar Sep 29 '22 23:09 balazsorban44

@balazsorban44 Conflicts fixed! It was just the readmes.

fmontes avatar Oct 01 '22 00:10 fmontes