next.js icon indicating copy to clipboard operation
next.js copied to clipboard

Update with-reasonml to with-rescript example

Open ryyppy opened this issue 4 years ago • 1 comments

Hey!

ReasonML & BuckleScript have officially rebranded to ReScript, so I'd like to deprecate with-reasonml in favour of a with-rescript example.

I updated all the dependencies and converted the original example to ReScript / React.

(will follow up with another PR for with-reasonml-todo later on)

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • [X] Make sure the linting passes

ryyppy avatar May 07 '21 17:05 ryyppy

Hi @ryyppy, there seem to be merge conflicts here, do you have the intention to bring this PR up-to-date? If not, let's close it for now. Thanks either way! :pray: :green_heart:

balazsorban44 avatar Sep 30 '22 00:09 balazsorban44

Closing as stale – if you would like to continue this, please open a new PR and we can take a look. Thank you so much! 🙏

leerob avatar Jan 04 '23 15:01 leerob