ms icon indicating copy to clipboard operation
ms copied to clipboard

Typing: ms with `StringValue` should not accept options

Open meshuamam opened this issue 1 year ago • 1 comments

Currently, the definition of ms in the typing is:

declare function ms(value: StringValue, options?: Options): number;
declare function ms(value: number, options?: Options): string;

the StringValue version should not accept options, since it doesn't use it

meshuamam avatar Jun 05 '23 20:06 meshuamam

Great catch @meshuamam. Would you be interested in raising a PR with that change?

mrmckeb avatar Jun 16 '23 07:06 mrmckeb