vercel
Viewing the source of hyperpower in the terminal activates the wow mode command
Was wondering what was going on for while, seems like a problem that the 'wow' command is being executed just by viewing a text file that contains the string that toggles it.
E.g.
vim ~/.hyperterm_plugins/node_modules/hyperpower/index.js
Then alternate between gg and G to jump to top/bottom of file.
Or, just cat it:
cat ~/.hyperterm_plugins/node_modules/hyperpower/index.js
It looks like the issue is on line 18-19 in the index.js file. The regex matches against the text from action.data. When we are viewing the index.js file, the regex matches because the text of the file itself is part of action.data
We could do a more strict regex, and check that the regex starts with the shell prefix.
/^bash: (wow: command not found|command not found: wow)/
This would interfere with #1 though; I haven't worked on other shells so I'm not sure what their exact output looks like.
well, I cannot figure out how to turn on wow mode until reaching this issue page:)
Hi @mocheng!
You can toggle "wow" mode by typing "wow" inside of hyperterminal.
I couldn't turn on wow mode either. Only other plugin I have is atom dark theme.
Actually I'm having trouble with hyperpower in general. Perhaps I'm forgetting something?
Here it is in my plugins:
Current version:
But wow command doesn't work:
I'm using hyper 1.3.1 OSX: 10.12.3
I can pull resquest a fix. But I've remember seeing something about that being fixed already
https://github.com/zeit/hyperpower/pull/29/files @matthew-groth maybe update your hyper.
Yes this ^ (I replied, but then realised it was already fixed and deleted my comment) but also, please start a new issue for unrelated problems with wow as this is about a specific issue (see title).
Namely: Reading a file should not trigger a command. If this becomes a common pattern in Hyper plugins, this is arguably an attack vector.