hyper
hyper copied to clipboard
Hyper Sessions restoration
Working on this again
Iteration circle into multiple PR. Closes Issues #785, #567
Provide
app quit and process quit -> state restoration after shutdown / restart
This PR includes important changes in order to allow sessions record and restoration.
Concern
At the moment, the session is not affiliated to any opened tabs or splits in the win
object. Sessions are created and then added to the sessions map in the win
object so each win inside the windowsSet
has multiples session.
Update
- Add win folder
- Add window object extanding
BrowserWindow
- window now have a
Set
ofTab
-
Tab
now include a root Pane and each pane havechilds
Apply hyper
Record
- [x] periodically save state
- [x] record all windows positions and sizes
- [x] record windows opened tabs
- [x] record tab root Pane and childs
- [x] record each Pane session cwd
Restoration
- [x] restore windows
- [x] restore windows tabs
- [x] restore tab Pane and child
- [x] restore Pane session cwd
This way, we can record the windowSet
object and apply the restoration on restart and reload the precedent recorded state.
+1 please add this fast ;D
@ivands Still have a few glitch! But working on it!
Commit e1ee608 close #1046
@matheuss @rauchg Review Needed
+1 Desperate for this!
+1
+1
Great work, @ppot! I resolved the conflicts locally to test it and it looks amazing to me.
The code and the new organization also looks great to me, but ultimately I'd like to see an opinion from @rauchg and @ekmartin about it 🙌
Any progress on this?
"Priority: OMG Maximum label 8 days ago" :D
Any chance of this getting merged soon? Soon-ish? Ever...? Thanks!
@echolevel Yes! After my rework of the UI! Better integration :)
Any word on this? Thanks!
+1
I will rework on this after #1509 land
Seem it won't be anytime soon.
Since #1876 Landed. I can move forward with this. It might be in smaller chunk! @albinekb @chabou What do you think?
I miss this feature so much, hope it will be merged some day. 😞
@VladShcherbin Haha will need improvement hehe ;)
Good news. Working on this again!
@ppot hey, any news on this one? 🗞
@VladShcherbin Yes. Im slowly reworking the internals of Hyper. Which take some times with my busy schedule. Not forgotten thought. This PR is old and the code base changed a lot. So i'm not rebasing haha. Starting fresh.
@ppot You have many, appreciative people cheering for your work, regardless of pace. 👏
Whenever it lands, very much looking forward to the new functionality.
I'm waiting for this feature. Keep up the good work. @ppot 👍
Will work on f/restoration
since there are many changes.
+1 @ppot How's it coming along? I would absolutely love this feature! is there anything I can help with?
If you think it's possible, I would like to help too! This is a great feature.
Most of the team is currently working on rolling out all the kinks that came with the switch to xterm.js
in 2.x, so that we can release it to everyone on the stable
channel.
I think it's best to wait with implementing this until then, since it requires pretty big changes, and combining that with all the other changes in 2.x currently would just extend the timeframe for 2.0 release.
We will be able to tackle this after the 2.0 release! 🎉
Since, switching to xterm affect the Term interface, I don't want to be constantly reworking code to match update change. So waiting on 2.0 for a working session restoration. Constantly looking at code change and see what can be upgraded and changed.
@rightaway Each windows will be restored with their specific layouts.