hyper icon indicating copy to clipboard operation
hyper copied to clipboard

Hyper Sessions restoration

Open ppot opened this issue 7 years ago • 65 comments

Working on this again

Iteration circle into multiple PR. Closes Issues #785, #567

Provide

app quit and process quit -> state restoration after shutdown / restart

This PR includes important changes in order to allow sessions record and restoration.

Concern

At the moment, the session is not affiliated to any opened tabs or splits in the win object. Sessions are created and then added to the sessions map in the win object so each win inside the windowsSet has multiples session.

Update

  • Add win folder
  • Add window object extanding BrowserWindow
  • window now have a Set of Tab
  • Tab now include a root Pane and each pane have childs

Apply hyper

Record

  • [x] periodically save state
  • [x] record all windows positions and sizes
  • [x] record windows opened tabs
  • [x] record tab root Pane and childs
  • [x] record each Pane session cwd

Restoration

  • [x] restore windows
  • [x] restore windows tabs
  • [x] restore tab Pane and child
  • [x] restore Pane session cwd

This way, we can record the windowSet object and apply the restoration on restart and reload the precedent recorded state. hyper_restore

ppot avatar Oct 30 '16 21:10 ppot

+1 please add this fast ;D

ivands avatar Nov 15 '16 21:11 ivands

@ivands Still have a few glitch! But working on it!

ppot avatar Nov 16 '16 01:11 ppot

Commit e1ee608 close #1046

ppot avatar Nov 28 '16 00:11 ppot

@matheuss @rauchg Review Needed

ppot avatar Nov 28 '16 00:11 ppot

+1 Desperate for this!

echolevel avatar Dec 12 '16 16:12 echolevel

+1

felipemrodrigues avatar Dec 14 '16 23:12 felipemrodrigues

+1

echolevel avatar Jan 02 '17 14:01 echolevel

Great work, @ppot! I resolved the conflicts locally to test it and it looks amazing to me.

The code and the new organization also looks great to me, but ultimately I'd like to see an opinion from @rauchg and @ekmartin about it 🙌

matheuss avatar Jan 02 '17 19:01 matheuss

Any progress on this?

echolevel avatar Jan 10 '17 18:01 echolevel

"Priority: OMG Maximum label 8 days ago" :D

Stanzilla avatar Jan 10 '17 18:01 Stanzilla

Any chance of this getting merged soon? Soon-ish? Ever...? Thanks!

echolevel avatar Jan 21 '17 14:01 echolevel

@echolevel Yes! After my rework of the UI! Better integration :)

ppot avatar Jan 22 '17 19:01 ppot

Any word on this? Thanks!

echolevel avatar Mar 28 '17 11:03 echolevel

+1

RutrackerOrg avatar May 05 '17 05:05 RutrackerOrg

I will rework on this after #1509 land

ppot avatar May 06 '17 14:05 ppot

Seem it won't be anytime soon.

ppot avatar May 12 '17 23:05 ppot

Since #1876 Landed. I can move forward with this. It might be in smaller chunk! @albinekb @chabou What do you think?

ppot avatar Jun 10 '17 00:06 ppot

I miss this feature so much, hope it will be merged some day. 😞

vladshcherbin avatar Jul 26 '17 01:07 vladshcherbin

@VladShcherbin Haha will need improvement hehe ;)

ppot avatar Jul 26 '17 18:07 ppot

Good news. Working on this again!

ppot avatar Aug 11 '17 14:08 ppot

@ppot hey, any news on this one? 🗞

vladshcherbin avatar Aug 30 '17 20:08 vladshcherbin

@VladShcherbin Yes. Im slowly reworking the internals of Hyper. Which take some times with my busy schedule. Not forgotten thought. This PR is old and the code base changed a lot. So i'm not rebasing haha. Starting fresh.

ppot avatar Sep 01 '17 00:09 ppot

@ppot You have many, appreciative people cheering for your work, regardless of pace. 👏

Whenever it lands, very much looking forward to the new functionality.

ggamel avatar Sep 01 '17 01:09 ggamel

I'm waiting for this feature. Keep up the good work. @ppot 👍

imekachi avatar Oct 05 '17 03:10 imekachi

Will work on f/restoration since there are many changes.

ppot avatar Oct 08 '17 01:10 ppot

+1 @ppot How's it coming along? I would absolutely love this feature! is there anything I can help with?

Subwater avatar Oct 18 '17 12:10 Subwater

If you think it's possible, I would like to help too! This is a great feature.

matheushf avatar Oct 18 '17 12:10 matheushf

Most of the team is currently working on rolling out all the kinks that came with the switch to xterm.js in 2.x, so that we can release it to everyone on the stable channel.

I think it's best to wait with implementing this until then, since it requires pretty big changes, and combining that with all the other changes in 2.x currently would just extend the timeframe for 2.0 release.

We will be able to tackle this after the 2.0 release! 🎉

albinekb avatar Oct 18 '17 13:10 albinekb

Since, switching to xterm affect the Term interface, I don't want to be constantly reworking code to match update change. So waiting on 2.0 for a working session restoration. Constantly looking at code change and see what can be upgraded and changed.

ppot avatar Oct 18 '17 15:10 ppot

@rightaway Each windows will be restored with their specific layouts.

ppot avatar Jan 14 '18 20:01 ppot