hyper icon indicating copy to clipboard operation
hyper copied to clipboard

perf: avoid gpu memory increase

Open robinfai opened this issue 1 year ago • 3 comments

This modification can effectively control the memory usage growth of GPU processes as the number of tabs increases. In our internal terminal client, this modification achieved a 75% reduction in overall memory usage at the P95 percentile.

robinfai avatar Aug 08 '23 15:08 robinfai

Thanks for the pr. I think we should be able to use the fit addon when term gets active again instead of calling internal methods. Other than that, it looks good.

LabhanshAgrawal avatar Aug 10 '23 07:08 LabhanshAgrawal

Hi there, Thank you for contributing to Hyper! You can get the build artifacts from here. Here are screenshots of Hyper built from this pr. Imgur ImagesImgur ImagesImgur Images

github-actions[bot] avatar Aug 10 '23 07:08 github-actions[bot]

Thanks for the pr. I think we should be able to use the fit addon when term gets active again instead of calling internal methods. Other than that, it looks good.

Because this size adjustment only involves the visible state of the terminal on the client-side, it is desired to keep the related operations within the client scope. Using the Fit addon for size synchronization involves exchanging size information between the client and the server, which may introduce some side effects.

robinfai avatar Aug 16 '23 02:08 robinfai