hyper icon indicating copy to clipboard operation
hyper copied to clipboard

Add `drawBoldTextInBrightColors` setting

Open comicchang opened this issue 2 years ago • 3 comments

This PR adds a option to set drawBoldTextInBrightColors to xterm.js.

This should resolve #5361 #2836 ##973

Example hyper.json

{
  "$schema": "./schema.json",
  "config": {
    "drawBoldTextInBrightColors": false,
    "colors": {
      "black": "#073642",
      "red": "#dc322f",
      "green": "#859900",
      "yellow": "#b58900",
      "blue": "#268bd2",
      "magenta": "#d33682",
      "cyan": "#2aa198",
      "white": "#eee8d5",
      "lightBlack": "#586e75",
      "lightRed": "#cb4b16",
      "lightGreen": "#586e75",
      "lightYellow": "#657b83",
      "lightBlue": "#839496",
      "lightMagenta": "#6c71c4",
      "lightCyan": "#93a1a1",
      "lightWhite": "#fdf6e3",
      "limeGreen": "#32CD32",
      "lightCoral": "#F08080"
    },
...
  },
...
}

current master or this PR with drawBoldTextInBrightColors: true image

this PR with drawBoldTextInBrightColors: false image

comicchang avatar Feb 08 '23 06:02 comicchang

Thanks for the contribution, the new config structure is not fully finalized, I'm thinking of grouping some xterm related options in a separate key. I'll keep this pr open till the structure is finalized and then we can work on getting this merged.

LabhanshAgrawal avatar Feb 12 '23 11:02 LabhanshAgrawal

Hi, I just want to follow up on this thread. Is the new config structure fully finalized now so that this configuration option can be added? I tested the changes in this PR (with some minor modifications) on my local branch and it worked as expected. It will be great to have this feature in the released version so that I don't have to run my local build. Thanks!

weiqisun avatar Feb 06 '24 23:02 weiqisun

@weiqisun Thanks for your comment, fixed.

comicchang avatar Feb 07 '24 01:02 comicchang