hyper icon indicating copy to clipboard operation
hyper copied to clipboard

Support electron flags

Open glyh opened this issue 3 years ago • 4 comments

Is your feature request related to a problem? Please describe. On wayland, XWayland doesn't have good HiDPI support. By default electron will use X for rendering, thus the window is blurring on wayland

Describe the solution you'd like A clear and concise description of what you want to happen. Support electron-flags.conf, so that we can add the following to support Wayland native render:

--enable-features=UseOzonePlatform
--ozone-platform=wayland

glyh avatar Feb 02 '22 04:02 glyh

I don't see any documentation on this electron-flags.conf file I was anyways considering adding electron flags in hyper config, so you can maybe use that once it's done.

LabhanshAgrawal avatar Feb 02 '22 16:02 LabhanshAgrawal

+1 I also tried --ozone-platform=Wayland flag but without any success. For modern Linux Systems, this flag is mandatory for electron apps.

Maybe we can do:

if $WAYLAND_DISPLAY flags="--ozone-platform=Wayland " else flags=" " fi

This would solve all problems and old Legacy Systems would still function.

ghost avatar Feb 06 '22 11:02 ghost

Any updates? I can't pass the flags as well. It creates a scaling problem on hidpi screens. --enable-features=UseOzonePlatform --ozone-platform=wayland The error I got as below,

Disabling Chromium GPU blacklist
running in prod mode
electron will open file:///opt/Hyper/resources/app.asar/index.html
[249358:0302/153127.225936:ERROR:cursor_loader.cc(114)] Failed to load a platform cursor of type kNull
[249400:0100/000000.290884:ERROR:gpu_init.cc(457)] Passthrough is not supported, GL is egl, ANGLE is 
[1]    249358 segmentation fault (core dumped)  /opt/Hyper/hyper --enable-features=UseOzonePlatform --ozone-platform=wayland
[249400:0100/000000.498613:ERROR:sandbox_linux.cc(376)] InitializeSandbox() called with multiple threads in process gpu-process.  

anilgurses avatar Mar 02 '22 20:03 anilgurses

This would be really cool to see!

ceiphr avatar May 14 '22 05:05 ceiphr