hyper icon indicating copy to clipboard operation
hyper copied to clipboard

Hyper implicitly using Notepad to edit preferences

Open aaryanporwal opened this issue 3 years ago • 7 comments

  • [x] I am on the latest Hyper.app version
  • [x] I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: OS Name: Microsoft Windows 10 Home Single Language OS Version: 10.0.19041 N/A Build 1904

  • Hyper.app version: 3.0.2 (latest)

  • The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

Hyper implicitly uses Notepad.exe to edit its preferences, but from Windows 2004 onwards, notepad has become an optional feature and doesn't come pre-installed. This leads to the following error: image image

aaryanporwal avatar Apr 18 '21 14:04 aaryanporwal

It's not implicit, it's used as a fallback. https://github.com/vercel/hyper/blob/80c7e67a0d3c83baa2124ef5b1fa8a88f8b56808/app/config/open.ts#L55 It uses notepad when there isn't a default app for .js files.

RealCyGuy avatar Apr 18 '21 14:04 RealCyGuy

I think wordpad is still preinstalled, it can be a fallback for notepad.

RealCyGuy avatar Apr 18 '21 15:04 RealCyGuy

Yeah wordpad is a better fallback, thanks!

aaryanporwal avatar Apr 18 '21 21:04 aaryanporwal

If you don't have Notepad, that's a bug. Notepad is still installed by default on Windows 10.

https://docs.microsoft.com/en-us/windows-hardware/manufacture/desktop/features-on-demand-non-language-fod

Stanzilla avatar May 16 '21 00:05 Stanzilla

It is under optional features: image https://answers.microsoft.com/en-us/windows/forum/windows_10-files/notepad-missing-in-windows-10-v2004/aefadf15-e830-4279-b9a3-591581ebb35a

aaryanporwal avatar May 16 '21 07:05 aaryanporwal

Yes but no Notepad being installed is a bug and not intended.

Stanzilla avatar May 16 '21 13:05 Stanzilla

No notepad installed can be a decision ;)

Thus, the error message should be changed to:

" Cannot find the default editor for *.js files to open '.hyper.js'. Please make sure you have a default text editor set up to open *.js files. "

karstengresch avatar Nov 28 '22 19:11 karstengresch