Auto-update if all windows closed

[leo]

trafficstars

IMO, we should just restart automatically after downloading an update if no Hyper window is open.

[rauchg]

This is really clever

[einfallstoll]

As long as there is a notice I'm fine with that.

[albinekb]

I wouldn't expect that to happen...

[pablopunk]

From the electron auto-updater docs:

Note: autoUpdater.quitAndInstall() will close all application windows first and only emit before-quit event on app after that. This is different from the normal quit event sequence.

If there is no window open, shouldn't quitAndInstall() just restart it? I mean, I would assume that that's the expected behavior, isn't it working like that right now?

[ppot]

I prefer the macOS way. Give user the ability to update when they want.

[rauchg]

I like the Chrome way. Always run the latest, the least you bother the user the better.

[pablopunk]

I like the Chrome way. Always run the latest, the least you bother the user the better.

Thumbs up for that 🙌🏻

IMO for patches or even minor versions it should be automatic.

[rauchg]

Yep, in the case of no terminal sessions being open, for all cases I think

[AlbertoElias]

That would be great. How does the updating process work currently? Is it manual? I'm on Windows 10

[jhonnymoreira]

@rauchg is this issue valid yet? I started using Hyper a few days ago and I would like to contribute.

[leo]

Yep, I'd say we're happy to accept a PR for it! 😊

[jhonnymoreira]

thanks, @leo! Expect a PR soon. [=

[Stanzilla]

https://github.com/zeit/hyper/pull/2515