hyper icon indicating copy to clipboard operation
hyper copied to clipboard

showWindowControls on macOS?

Open FabriceCastel opened this issue 8 years ago • 13 comments

Currently this config option is ignored on macOS

It's a waste of space and makes me sad bear ;-;

Is there any way to work around this or plans in the future to make this option relevant on macOS as well?

Thanks

FabriceCastel avatar Dec 13 '16 06:12 FabriceCastel

+1 for this option on macOS!!

I am curious about why this feature need to be ignored on Mac

weihanglo avatar Dec 17 '16 14:12 weihanglo

Might this have anything to do with:

https://github.com/zeit/hyper/blob/master/app/index.js#L137

As opposed to tlteBarStyle="hidden"?

FabriceCastel avatar Jan 07 '17 18:01 FabriceCastel

It's ignored on macOS because we already have the traffic lights and they're beautiful ☺️

matheuss avatar Jan 21 '17 18:01 matheuss

It's ignored on macOS because we already have the traffic lights and they're beautiful

That's just, like, your opinion, man.

I'm using hyper-autohide-tabs and not being able to hide the window controls looks like garbage:

screen shot 2017-03-17 at 09 58 31

Is it a technical challenge to allow hiding the controls on macOS? Can I help solve it? Having a showWindowControls option that is ignored on certain platforms seems like a bug to me, not a feature.

chadoh avatar Mar 17 '17 14:03 chadoh

@chadoh well it's our (author, @rauchg, and me, main maintainer) opinion. We don't want to include it on core ¯_(ツ)_/¯

You can easily do it with a plugin – you can override the options passed to the BrowserWindow – therefore, you can hide the traffic lights 👌

matheuss avatar Mar 17 '17 14:03 matheuss

With all due respect @matheuss having platform-dependant feature support doesn't seem like a good policy to have. It seems like a total hack to require a plugin to do something that's natively supported on other platforms.

It's not about how easy or hard it is so much as it is about this being a consistent experience across linux/windows/macos.

FabriceCastel avatar Mar 17 '17 14:03 FabriceCastel

This is still one of the reasons I haven't switched to Hyper as my main terminal.

chadoh avatar Jun 22 '17 21:06 chadoh

We want this too

markpanado avatar Mar 11 '19 00:03 markpanado

@matheuss With the utmost of respect, I'm not sure I understand your reasoning. You'd rather not allow us to decide if we should show/hide the traffic lights on our own machines because you deem them to be aesthetically pleasing?

As far as I can tell no one is arguing for the default to be a specific thing; we're merely asking for the ability to decide for ourselves.

rehatkathuria avatar Jan 15 '20 18:01 rehatkathuria

:+1: Sounds great to have it be respected on macOS as well, by reasoning above (3+ years ago 😮) doesn't make sense

matheuss avatar Jan 15 '20 18:01 matheuss

@matheuss <3

rehatkathuria avatar Jan 15 '20 18:01 rehatkathuria

@matheuss Any updates on this?

rehatkathuria avatar Feb 12 '20 10:02 rehatkathuria

Still waiting 😅

puneetred avatar Oct 17 '23 06:10 puneetred