examples icon indicating copy to clipboard operation
examples copied to clipboard

Update deployment GitHub workflows

Open johnnygerard opened this issue 1 year ago • 1 comments

Your workflows (preview.yaml, production.yaml) still use actions/checkout@v2 instead of actions/checkout@v4.

Also, the workflows specify the npm version vercel@canary. Why not use vercel@latest?

johnnygerard avatar Jan 25 '24 14:01 johnnygerard

When using these files, while trying to deploy to Vercel I'm getting this error:

Type error: 'Navbar' cannot be used as a JSX component. Its type '() => Promise<Element>' is not a valid JSX element type. Type '() => Promise<Element>' is not assignable to type '(props: any, deprecatedLegacyContext?: any) => ReactNode'. Type 'Promise<Element>' is not assignable to type 'ReactNode'. 24 | 25 | <body className="bg-black">

26 | <Navbar /> | ^ 27 | <main 28 | id="skip" 29 | className="min-h-[calc(100dvh-4rem)] md:min-h[calc(100dvh-5rem)]"

I didn't change anything in the nextjs-subscription-starter template.

When deploying directly from Vercel everything goes flawlessly.

josips9 avatar Dec 09 '24 21:12 josips9